build(deps-dev): bump postcss-loader from 7.3.4 to 8.1.1 #337
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [postcss-loader](https://github.com/webpack-contrib/postcss-loader) from 7.3.4 to 8.1.1. - [Release notes](https://github.com/webpack-contrib/postcss-loader/releases) - [Changelog](https://github.com/webpack-contrib/postcss-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/postcss-loader@v7.3.4...v8.1.1) --- updated-dependencies: - dependency-name: postcss-loader dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
Not patch bumped
|
…yarn/postcss-loader-8.1.1
ChangeLog README updatedfeat(themes): ChangeLog README updated (#341) ChangeLog README updated
|
/autoupdate |
|
commit 88ce237749dbc32267438f3067a846dd3741fca7
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Mon Sep 9 16:43:13 2024 +0300
feat(themes): Remove `is-notifiable` prop from inline `salla-user-settings` tag (#444)
remove `is_notifiable `
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit d1e4204c67f30792fe548f74b1a156c991231c0f
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Mon Sep 9 14:53:15 2024 +0300
fix(themes): TWILIGHT-2508 tracking link should open in new tab (#463)
commit f03d2d593615546e28a6684715f7b6ffb568a214
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Sun Sep 8 22:24:52 2024 +0800
feat(themes): Unify Release Date Formats (#461)
Update CHANGELOG.md
commit c6520c6281aa4293c74d3ba6170cddaa64257d3d
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Sun Sep 8 15:17:47 2024 +0300
feat(themes): ChangeLog July 10th Update typo fixed (#459)
commit 89c1dc89202f14c683eb1a93bbc77c55521b2f94
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Tue Sep 3 15:02:25 2024 +0300
feat(themes): ChangeLog July 10th Update (#458)
commit cfa85b8ac555e24f00dd003134e5e3b8171b255c
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Sep 3 11:55:28 2024 +0300
feat(themes): add appointment in order options (#450)
* feat: add appointment in order options
* feat: add table header for order options
---------
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit 0d533ed8b4a67a7c1fb50d6e34ec923d588a56c2
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Sat Aug 31 02:57:20 2024 +0300
fix(themes): build assets (#454)
assets
commit 75a15816353b40b7458e629c903031af441ed55f
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Sat Aug 31 02:49:58 2024 +0300
Update CHANGELOG.md (#409)
* Update CHANGELOG.md
* Update CHANGELOG.md
commit bfca676307b305c75bf50c7bbdc59fdde2b6a2d8
Author: Salah Alkhwlani <alkhwlani@yandex.com>
Date: Sat Aug 31 02:35:21 2024 +0300
hotfix(core): Trigger update assets (#453)
Update README.md
commit 73fa95c9dd05caf8daf854596d022caa435c6dbe
Author: Salah Alkhwlani <alkhwlani@yandex.com>
Date: Sat Aug 31 02:12:58 2024 +0300
feature(cache): drop cache main menu using localstorage
commit a514828391c7037d92550b3646122772be12ac08
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Thu Aug 29 12:55:30 2024 +0300
fix(themes): fix align of text in my account page (#452)
* fix(themes): fix align of text in my account page
* fix(core): upgrade twilight-components package + build
commit b51053fd7ffffa2e08673a9c2afc2fbc0d42749e
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Sun Aug 25 14:28:08 2024 +0300
fix(themes): change the current viewport meta tag (#451)
commit 1ca41c58007b08c51d81c2070579c4ddd21e1963
Author: Ahmed Alkatheri <68098769+AhmedAlkatheri@users.noreply.github.com>
Date: Mon Aug 19 13:50:48 2024 +0300
fix(themes): fix show order opitons (#447)
fix(STORE-1893): Fix Appointment field issues
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit 5e596b2ff0f68912710e549c0792664d304c1139
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Mon Aug 19 11:52:04 2024 +0300
feat(themes): TWILIGHT-1516 add shipment track link (#446)
* feat(themes): TWILIGHT-1516 add shipment track link
* adjust shipment tracking url style
* rever changes in customer.twig
* Update single.twig translation
commit 13fc546a2cf8deefa9e468d54460854ff7c5ee3a
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Mon Aug 19 11:34:05 2024 +0300
fix(themes): 🐛 Fix memory leak error in product-card (#445)
* Enhance wishlist event listeners
* Enhance solution
* Revert "Enhance solution"
This reverts commit 451a6e66ed9fa43477b85412c4b299419c481726.
* 💡IMPROVE: handle added products from localStorage
* 🐛FIX: get product id's as numbers from localStorage
* 💡IMPROVE: move listeners and toggle logic to `app.js`
commit de4afbb3878cd72c091d57ba902e80190e46dae4
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Sun Aug 11 16:47:30 2024 +0300
fix(themes): Fix the error message style when user upload avatar size more than 2 MB (#439)
* fix(themes): fix error message style
* fix(core): build
commit bedc6d98d5eb871038c3092123d876952db21023
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun Aug 11 13:24:00 2024 +0300
fix(themes): ✨ Finalize remaining points for Shipment Tracking feature (#438)
commit cb1e00f87f01445f509d83637b6575c054a2a788
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Wed Aug 7 16:32:08 2024 +0300
feat(themes): ⭐️ Enhanced reviews system phase 2 (#435)
* 🌟ADD: Support Edit & Delete reviews
* Update package.json
* Build
* Update twilight + Build
commit 9c81c7da6305e6fad3e1ad82f4b22d992b348c0c
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Mon Aug 5 15:22:19 2024 +0300
fix(themes): Unavailable option fix (#434)
* move out-of-stock to below price area
* Update single.twig
* Update app.css
commit 505efd0bb87fc93cb71d6fd524f0f669fc9970d4
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Mon Aug 5 11:19:00 2024 +0300
fix(themes): display text 'out of stock ' with-unavailable-Option (#433)
* update packages.json
* out-of-stock if has no price
* assets
* fix(themes): fix height of out-of-stock phrase
---------
Co-authored-by: ahmed-salah <ahmed.s@salla.sa>
commit 23b0def0db0321cbe0dc185782aa753c4b258d9e
Author: Mohammed Alabsi <devlomingo@gmail.com>
Date: Thu Aug 1 19:03:30 2024 +0300
Revert "fix(core): upgrade twilight-components" (#431)
Revert "fix(core): upgrade twilight-components (#430)"
This reverts commit a5e9a98dd8678148c73106502727d76a2a9d5eaa.
commit a5e9a98dd8678148c73106502727d76a2a9d5eaa
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Thu Aug 1 14:56:38 2024 +0300
fix(core): upgrade twilight-components (#430)
commit 8b341c5ee26e37f49c6b17dc45b67012276a34d7
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Tue Jul 23 11:37:24 2024 +0300
feat(themes): ⭐️ Enhanced reviews system (#424)
Support rating images in single order page + stars label
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit a0005f9189a86227e33265b5b61041fc671d59b8
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Wed Jul 17 16:18:44 2024 +0300
fix(core): upgrade twiligh package + build (#423)
commit 393cd2e5d34cc371c900592db4eae1ecc6ea0978
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Jul 16 13:13:03 2024 +0300
feat(themes): TWILIGHT-1146 handle protected digital files (#422)
* feat: handle protected digital files TWILIGHT-1146 TWILIGHT-2096
* Update single.twig
commit f72690c3cd66384259d25bb3c4c4547f10f44854
Author: Mohammed Alabsi <devlomingo@gmail.com>
Date: Wed Jul 10 16:45:17 2024 +0300
feat(theme) : Digital product options (#419)
commit 6b98ef7e838742cb8f59cd6ccae803ad4698494d
Author: Mohammed Alabsi <devlomingo@gmail.com>
Date: Wed Jul 10 16:00:22 2024 +0300
feat(catalog): Advanced code management (#418)
commit 70cc3126e71d6c4b9ad02f064be1746c2d6a94c1
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Thu Jul 4 14:52:02 2024 +0300
fix(themes): Upgrade twilight components (#416)
fix(core): Upgrade twilight-components package
commit e3b33765a496c8045814d807b92bc66a7fba4a94
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue Jul 2 13:06:21 2024 +0300
fix(core): upgrade twilight-components package (#414)
commit 82b26c31c86fcc2ffcd45dd79efca64f9c6a0add
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Mon Jul 1 09:52:47 2024 +0300
fix(themes): Enhance booking field (#411)
* Enhance booking field
* Update app.css
commit 692e0e490163ae818c4b6aa704d30670aea153bc
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun Jun 30 17:43:37 2024 +0300
feat(TD-578): 📆 Support Order Option Appointment Field (#410)
commit 523d2735c3dd916b8abab9cdbabff021bed981bd
Author: Ahmed Alkatheri <68098769+AhmedAlkatheri@users.noreply.github.com>
Date: Fri Jun 28 22:39:40 2024 +0300
fix(themes): Revert fix product's options validation (#405)" (#408)
Revert "fix(themes): fix product's options validation (#405)"
This reverts commit 325bbfe1cf742527e192cf57f74775113f82dca7.
commit 9dd1741845434054099900e47a148c6062f1c4b5
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Thu Jun 27 15:50:00 2024 +0300
feat(themes): Bulk ChangeLog Updates (#406)
Bulk ChangeLog Updates
commit 325bbfe1cf742527e192cf57f74775113f82dca7
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Wed Jun 26 16:22:51 2024 +0300
fix(themes): fix product's options validation (#405)
* fix(core): Upgrade twilight-components package
* fix(themes): fix product's options validation
* fix(core): build
* Update src/assets/js/product.js
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
commit c1112f7dc06d64f554247a2fa761b45a5840dd2d
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Wed Jun 12 19:01:26 2024 +0300
fix(themes): fix console.error due to menu-item on hover (#401)
commit b0e628b3673a89516c25e489cc8ec79fc2a30d11
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue Jun 11 16:19:22 2024 +0300
fix(themes): fix style of product's description (#397)
* fix(themes): fix style of product's description
* fix(themes): delete unused file
* fix(core): upgrade twilight-components package + build
* fix(themes): fix line-height
commit b55efe3a9bb9fd1f35196881fff816d3a9967a73
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Mon Jun 10 12:21:19 2024 +0300
feat(themes): Support `salla-comments` in testimonials page (#394)
* Support `salla-comments` in testimonials page
* wip
* wip
* wip
* Update testimonials.twig
* Update testimonials.twig
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 9b26285ee346f13f6baa4dec977051a2fcd8da8e
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Thu May 30 09:35:26 2024 +0300
fix: display progress bar in product's card (#392)
* fix: display progress-bar in product's card
* fix: cleanUp Code
commit 0c0bddcc85c603ffa68b75cc997fed78a0a19843
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Wed May 29 17:28:21 2024 +0300
fix(core): upgrade twilight-components package + build (#391)
commit d4bd3c333cd7e3712523e470647a3135b231bd44
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Wed May 29 16:24:01 2024 +0300
fix: Eager Loading Custom Components JS Files (#390)
* add data-cfasync="false" to product-card.js script tag
* add data-cfasync="false" to wishlist-card.js script tag
* Update wishlist.twig
* Update master.twig
* Update master.twig
* add defer to wishlist-card script
commit e88200705e5b233f3e4a89965c276bf5664dda59
Author: Mohammed Alabsi <devlomingo@gmail.com>
Date: Sun May 26 16:22:16 2024 +0300
Revert "feat(themes): ✨ Support Using `source`, `source_value` in home components" (#384)
Revert "feat(themes): ✨ Support Using `source`, `source_value` in home compon…"
This reverts commit 26ed8445a1d944e3ffde20a1b2156397f44f452c.
commit 26ed8445a1d944e3ffde20a1b2156397f44f452c
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun May 26 15:31:54 2024 +0300
feat(themes): ✨ Support Using `source`, `source_value` in home components (#309)
* feat(themes): ✨ Support Using `source`, `source_value` in home components
* update other usages
* rollback changes
* rollback changes
---------
Co-authored-by: Mohammed Alabsi <devlomingo@gmail.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
Co-authored-by: Abubaker Moharram <bakri_moharram@hotmail.com>
commit 2547f9f948ae798b81dc7fb774a2be2313b499bc
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Thu May 23 19:57:28 2024 +0300
feat(themes): ✨ Add Fast Checkout in Product Details Page (#301)
* Support mini checkout in single product page
* Link twilight locally
* Update single.twig
* Update master.twig
* Add static mini checkout url for testing purposes
* Upgrade mini-checkout - remove domain
* change twilight path
* Squashed commit of the following:
commit ec593e603390c8a3239ca9db0a13cf96d0b6c752
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 14 16:41:53 2024 +0300
fix(themes): remove unused files (#368)
* fix(themes): remove unused files
* Update footer.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 1088fd7baff3b6ed65c483efbdd648882aabe1a4
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Sun May 12 19:25:19 2024 +0800
Update CHANGELOG.md (#360)
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 0cd3a5e2a0c12e4462797a2e661270184f56554c
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Sun May 12 09:52:37 2024 +0300
feat(themes): 🔧 Enhancements for `custom-main-menu` (#365)
* Update main-menu.js
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit d35657bcda572e66fb88216fa4cb982165f32434
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Thu May 9 13:22:41 2024 +0300
fix(themes): TD-174 avoid setting cache on miss (#364)
commit 82246537616b3d10eaae166c40086e241c33d8e3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Wed May 8 12:29:10 2024 +0300
fix(core): 🔧 Upgrade twilight package (#363)
* fix(core): 🔧 Upgrade twilight package
* ⚙️ WIP: Push Changes
commit a5c70947734b02aa7ed4575484c6001309d22bb4
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 7 16:29:53 2024 +0300
fix(themes): show overlay only on hover (#362)
commit 518ec3e1e88d0fc4d61ba75755036219a520410b
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun May 5 16:52:12 2024 +0300
fix(themes): 🐞 rename `without-customer` => `hide-customer-info` (#358)
* fix(themes): 🐞 rename `without-customer` => `hide-customer-info`
* Update testimonials.twig
commit e213699e402d0982c92a4c59bc2455005ed4d63a
Author: Ahmed Alkatheri <68098769+AhmedAlkatheri@users.noreply.github.com>
Date: Sun May 5 10:46:09 2024 +0300
fix(themes): support `limit`, `sort` and `without_customer` in salla-reviews (#357)
* fix(themes): fix reviews sort
* Update testimonials.twig
* Update testimonials.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit e3f72eb44a1d8bbf8a621e10b0aba3201e3d2e56
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Thu May 2 15:57:29 2024 +0300
feat(themes): 💬 Support `salla-notifications` component (#355)
* Support `salla-notifications`
* Update user-pages.scss
commit f6daf450989fda0f87186d35b0b4ddfa2bdfaa9f
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:45:44 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 150a44573184b1b32b5c2a45cbf3f23d2695ae69
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:41:37 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit e0a843c90c986a8a5bb9ad28a65fedfa54e58af9
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:40:45 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 0d9ba68d16ad007981b21dcd3f995c9ec6e7760d
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Mon Apr 29 15:34:26 2024 +0300
fix(themes): show "display-all-button" in testimonials section only if option is activated (#354)
* fix(themes): show "display-all-button" in testimonials section only if option is activated
* fix(themes): cleanUp code
* fix(themes): display button based on custom option not general options
commit 716f3b7874e0eea67fa2dee7926e28aa742cdadd
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Mon Apr 29 17:59:30 2024 +0800
Update CHANGELOG.md (#353)
* Update CHANGELOG.md
Added new updates to changelog
New release for theme Raed - v1.145.0
: Features:
Support main menus via api
Support salla-reviews component
Support salla-breadcrumb component
Support salla-order component
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 896904df8755aa75738fa3b6802035b4c8ee6040
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun Apr 28 18:16:46 2024 +0300
fix(themes): 🐞 Enhancements For `salla-breadcrumb` styles (#351)
commit 6aca33215935d8cbaf4b94799b97a497bcfdb5f8
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:38:21 2024 +0300
refactor(themes): replace orders list with salla-order component (#345)
* refactor: replace orders list with salla-order component
* fix: remove unused styles associated with order
* Build
* update twilight
* Build Assets
---------
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 123ee1b6e2991e27a5ca72636e70cc624846846a
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:04:04 2024 +0300
feat(themes): 💬 Support `salla-reviews` `salla-breadcrumb` components (#343)
* refactor: replace testimonial code with salla-reviews component
* fix: remove unneccessary styles
* Update package.json
* Build Assets + add components styles
* wip
* fix: resolve style issue with slider block padding
* feat(themes): ✨ Support `salla-breadcrumb`
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 4d7bd78d3847649b233d4be067cf42d2b4251385
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Sun Apr 28 15:21:26 2024 +0300
feat(themes): 💭Two New Updates Released 💭 (#350)
💭Two New Updates Released 💭
commit 24a5997e7dbcdf0db33af4069b03d5b5e8e4796d
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 25 11:04:01 2024 +0300
refactor(themes): TD-174 custom main menu (#349)
* refactor(themes): TD-174 custom main menu
* Update menu.twig
---------
Co-authored-by: Ibrahim M. Abdallah <WOXY@Outlook.com>
commit 43957865678f484329e604054c506b22d0d1114e
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Apr 25 09:29:46 2024 +0300
refactor(themes): validate product options before making update price request (#347)
* ref: validate product options before update price request
* assets
* ref: validate the whole form
* assets
commit f7e3a23a05d7b25c86c159dce38ada4feeffd6cd
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Apr 24 17:35:30 2024 +0300
✨ Detailed Description & Visual Icons Added (#342)
commit bf944cb4fda8db3fa7fbf7091d4140dd2d4328d5
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Wed Apr 24 12:38:06 2024 +0300
hotfix(themes): fix syncing assets (#346)
async assets
commit 01b4b1921d4ddfd2e9732930cefcff3c26ae1cc4
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Apr 23 11:02:36 2024 +0300
hotfix(themes): fix input quantity when max is one (#344)
* fix: make input quantity readonly when max is one
* assets
* ref: update ui without adding the attr
* assets
* ref: enhance code
* Revert "ref: enhance code" This reverts commit 9c532477c24a33a1ffd99fe7dc554be0ed855fb6
* ref: enhancing code
commit f6506db265ed08961bd6f496122730018667d92e
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Mon Apr 22 12:19:35 2024 +0300
feat(themes): ChangeLog README updated (#341)
ChangeLog README updated
commit 73790159a0494b4f7c1facb372d303a68607da73
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Thu Apr 18 12:31:00 2024 +0300
refactor: replace the user profile page with user-profile component (#336)
commit e843866727b503e42f86254b042d3da4c1f81435
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 18 11:39:37 2024 +0300
feat(themes): 📑 Create `CHANGELOG.md` (#335)
* feat(themes): 📑 Create `CHANGELOG.md`
* Update CHANGELOG.md
commit 5709109d1f99c6d6050b771fc3a522975a925cf0
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Thu Apr 18 10:01:27 2024 +0300
feat(themes): Documentation Link Updated (#323)
Documentation Link Updated
commit 0a5c477569ac25ce339eb7470a57f7708cc09d5d
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Wed Mar 27 11:19:57 2024 +0200
feat(themes):✨ Support new twilight components (#274)
* support footer, ad and comments components
* ⚙️ WIP: Push Changes
* Add comments component to single page
* Update app.css
* add contacts to header
* Update app.css
* Update app.css
* 🔄 created local '.github/workflows/' from remote '.github/rector/'
🛠️ CI: add rector
* Fix salla-social spacing in footer
* cleanup footer
* Cleanup
* return old comments component
* sync
* Build
* sync
* wip
* ⚙️ WIP: Push Changes
* wip
* resolve
* Sync public folder from master
* - .github/workflows/rector.yaml
* Drop `salla-notifications`
---------
Co-authored-by: anass-at <null>
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: devlomingo <devlomingo@gmail.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit 4ad6c491bfaafdac5cd65d77ed42514cb85872a0
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Mar 21 12:15:27 2024 +0300
feat(themes): support new component salla-offer (#332)
feat: support new component salla-offer
commit f314e063a807f103466d46c6d33434f214c6ec46
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 17:34:16 2024 +0300
fix(themes): 🐞 Reduce Tax Image Size (#331)
commit 8bca90b9639044473d96d6b5af7345827c2b22d3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 14:20:54 2024 +0300
feat(themes): ✨ Support Product Specs On Themes (#329)
* feat(themes): ✨ Support Product Specs On Themes
* Amend
* feat(themes): ✨ Support `product.has_metadata`
* feat(themes): ✨ Support `product.has_metadata`
* chore: upgrade twilight version
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit d572c6a2a332e5286b996baa0de1c4dabd23a516
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Wed Mar 13 14:11:36 2024 +0200
fix(themes): Disable loading on submit btn and open login modal directly if user is guest [cart page] (#328)
* Cart: disable loading on submit btn if user is guest
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit ca07029cc83cc29a3eac46ca19e98cb8eed187f6
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Mar 13 12:20:09 2024 +0300
themes(feat): Theme Features + Theme Components' docs reference links updated (#324)
Theme Features + Theme Components' docs reference links updated
commit 4396a65f5b0da64ddeca160784fc1f443ff1038f
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 12 15:03:41 2024 +0200
fix(themes): General fixes and Enhancements (#327)
* Display the submenu if it is off the page
* using infinity scroll in wishList page
* Display submenu if it is off the page ( using event mouseover )
* replace: 'images/s-empty.png' | asset to 'images/s-empty.png' | cdn
* Update .gitignore
* assets
---------
Co-authored-by: ahmed-salah <ahmed.s@salla.sa>
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 3a8a00d535eadd57246980b33c36d219c7e16b3e
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 5 11:26:03 2024 +0200
fix(themes): SEO enhances (#322)
* change danger to red-800
* Subtitle color fix
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 5ab5fcd96b90de69bf61da3ce2103e0c7d4b5099
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Feb 15 13:44:46 2024 +0300
hotfix(themes: fix price option with discount (#317)
* fix(themes): fix price in product details page
* Update single.twig
* assets
* Update product.js
* Update single.twig
commit 7b44b6a7b5cc0171538cb08ccd665ec13f88c715
Author: Salah Alkhwlani <yemenifree@yandex.com>
Date: Wed Feb 14 12:22:53 2024 +0300
⚙️ Update `twilight.json`
commit cf675280863ebaf261184b62371c5eabce5bc633
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Feb 13 10:38:55 2024 +0300
feat(themes): handle when cart option is applied to different categories (#315)
* feat: handle when cart option is applied to different categories
- handle the case when the cart option is applied to different categories and update the DOM accordingly
* fix: fix codacy suggesion
* Update single.twig
* assets
commit 4d70ac78881c86ecbf800473c184329b9d44e991
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:42:14 2024 +0300
rebuild
commit dc0fec83e7340ec06fc3d2f2527c4816b8e2c7ad
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:29:36 2024 +0300
Update README.md
commit c1159e2a08f902d971a304d4d328e2bcb06f3988
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:00:02 2024 +0300
rebuild
commit ceeac819aefcb183e999ebefe547282e54e246be
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 15:51:36 2024 +0300
rebuild
commit 31f15acdd89dd5be433e27e5574c10f4df33c2d6
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Sun Feb 11 14:28:12 2024 +0200
fix(themes): Quick buy shipping prop (#312)
* Update twilight
* assets
* support applePay is_require_shipping prop
* Build & Remove unneeded files
* Squashed commit of the following:
commit ec593e603390c8a3239ca9db0a13cf96d0b6c752
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 14 16:41:53 2024 +0300
fix(themes): remove unused files (#368)
* fix(themes): remove unused files
* Update footer.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 1088fd7baff3b6ed65c483efbdd648882aabe1a4
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Sun May 12 19:25:19 2024 +0800
Update CHANGELOG.md (#360)
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 0cd3a5e2a0c12e4462797a2e661270184f56554c
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Sun May 12 09:52:37 2024 +0300
feat(themes): 🔧 Enhancements for `custom-main-menu` (#365)
* Update main-menu.js
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit d35657bcda572e66fb88216fa4cb982165f32434
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Thu May 9 13:22:41 2024 +0300
fix(themes): TD-174 avoid setting cache on miss (#364)
commit 82246537616b3d10eaae166c40086e241c33d8e3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Wed May 8 12:29:10 2024 +0300
fix(core): 🔧 Upgrade twilight package (#363)
* fix(core): 🔧 Upgrade twilight package
* ⚙️ WIP: Push Changes
commit a5c70947734b02aa7ed4575484c6001309d22bb4
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 7 16:29:53 2024 +0300
fix(themes): show overlay only on hover (#362)
commit 518ec3e1e88d0fc4d61ba75755036219a520410b
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun May 5 16:52:12 2024 +0300
fix(themes): 🐞 rename `without-customer` => `hide-customer-info` (#358)
* fix(themes): 🐞 rename `without-customer` => `hide-customer-info`
* Update testimonials.twig
commit e213699e402d0982c92a4c59bc2455005ed4d63a
Author: Ahmed Alkatheri <68098769+AhmedAlkatheri@users.noreply.github.com>
Date: Sun May 5 10:46:09 2024 +0300
fix(themes): support `limit`, `sort` and `without_customer` in salla-reviews (#357)
* fix(themes): fix reviews sort
* Update testimonials.twig
* Update testimonials.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit e3f72eb44a1d8bbf8a621e10b0aba3201e3d2e56
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Thu May 2 15:57:29 2024 +0300
feat(themes): 💬 Support `salla-notifications` component (#355)
* Support `salla-notifications`
* Update user-pages.scss
commit f6daf450989fda0f87186d35b0b4ddfa2bdfaa9f
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:45:44 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 150a44573184b1b32b5c2a45cbf3f23d2695ae69
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:41:37 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit e0a843c90c986a8a5bb9ad28a65fedfa54e58af9
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:40:45 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 0d9ba68d16ad007981b21dcd3f995c9ec6e7760d
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Mon Apr 29 15:34:26 2024 +0300
fix(themes): show "display-all-button" in testimonials section only if option is activated (#354)
* fix(themes): show "display-all-button" in testimonials section only if option is activated
* fix(themes): cleanUp code
* fix(themes): display button based on custom option not general options
commit 716f3b7874e0eea67fa2dee7926e28aa742cdadd
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Mon Apr 29 17:59:30 2024 +0800
Update CHANGELOG.md (#353)
* Update CHANGELOG.md
Added new updates to changelog
New release for theme Raed - v1.145.0
: Features:
Support main menus via api
Support salla-reviews component
Support salla-breadcrumb component
Support salla-order component
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 896904df8755aa75738fa3b6802035b4c8ee6040
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun Apr 28 18:16:46 2024 +0300
fix(themes): 🐞 Enhancements For `salla-breadcrumb` styles (#351)
commit 6aca33215935d8cbaf4b94799b97a497bcfdb5f8
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:38:21 2024 +0300
refactor(themes): replace orders list with salla-order component (#345)
* refactor: replace orders list with salla-order component
* fix: remove unused styles associated with order
* Build
* update twilight
* Build Assets
---------
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 123ee1b6e2991e27a5ca72636e70cc624846846a
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:04:04 2024 +0300
feat(themes): 💬 Support `salla-reviews` `salla-breadcrumb` components (#343)
* refactor: replace testimonial code with salla-reviews component
* fix: remove unneccessary styles
* Update package.json
* Build Assets + add components styles
* wip
* fix: resolve style issue with slider block padding
* feat(themes): ✨ Support `salla-breadcrumb`
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 4d7bd78d3847649b233d4be067cf42d2b4251385
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Sun Apr 28 15:21:26 2024 +0300
feat(themes): 💭Two New Updates Released 💭 (#350)
💭Two New Updates Released 💭
commit 24a5997e7dbcdf0db33af4069b03d5b5e8e4796d
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 25 11:04:01 2024 +0300
refactor(themes): TD-174 custom main menu (#349)
* refactor(themes): TD-174 custom main menu
* Update menu.twig
---------
Co-authored-by: Ibrahim M. Abdallah <WOXY@Outlook.com>
commit 43957865678f484329e604054c506b22d0d1114e
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Apr 25 09:29:46 2024 +0300
refactor(themes): validate product options before making update price request (#347)
* ref: validate product options before update price request
* assets
* ref: validate the whole form
* assets
commit f7e3a23a05d7b25c86c159dce38ada4feeffd6cd
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Apr 24 17:35:30 2024 +0300
✨ Detailed Description & Visual Icons Added (#342)
commit bf944cb4fda8db3fa7fbf7091d4140dd2d4328d5
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Wed Apr 24 12:38:06 2024 +0300
hotfix(themes): fix syncing assets (#346)
async assets
commit 01b4b1921d4ddfd2e9732930cefcff3c26ae1cc4
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Apr 23 11:02:36 2024 +0300
hotfix(themes): fix input quantity when max is one (#344)
* fix: make input quantity readonly when max is one
* assets
* ref: update ui without adding the attr
* assets
* ref: enhance code
* Revert "ref: enhance code" This reverts commit 9c532477c24a33a1ffd99fe7dc554be0ed855fb6
* ref: enhancing code
commit f6506db265ed08961bd6f496122730018667d92e
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Mon Apr 22 12:19:35 2024 +0300
feat(themes): ChangeLog README updated (#341)
ChangeLog README updated
commit 73790159a0494b4f7c1facb372d303a68607da73
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Thu Apr 18 12:31:00 2024 +0300
refactor: replace the user profile page with user-profile component (#336)
commit e843866727b503e42f86254b042d3da4c1f81435
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 18 11:39:37 2024 +0300
feat(themes): 📑 Create `CHANGELOG.md` (#335)
* feat(themes): 📑 Create `CHANGELOG.md`
* Update CHANGELOG.md
commit 5709109d1f99c6d6050b771fc3a522975a925cf0
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Thu Apr 18 10:01:27 2024 +0300
feat(themes): Documentation Link Updated (#323)
Documentation Link Updated
commit 0a5c477569ac25ce339eb7470a57f7708cc09d5d
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Wed Mar 27 11:19:57 2024 +0200
feat(themes):✨ Support new twilight components (#274)
* support footer, ad and comments components
* ⚙️ WIP: Push Changes
* Add comments component to single page
* Update app.css
* add contacts to header
* Update app.css
* Update app.css
* 🔄 created local '.github/workflows/' from remote '.github/rector/'
🛠️ CI: add rector
* Fix salla-social spacing in footer
* cleanup footer
* Cleanup
* return old comments component
* sync
* Build
* sync
* wip
* ⚙️ WIP: Push Changes
* wip
* resolve
* Sync public folder from master
* - .github/workflows/rector.yaml
* Drop `salla-notifications`
---------
Co-authored-by: anass-at <null>
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: devlomingo <devlomingo@gmail.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit 4ad6c491bfaafdac5cd65d77ed42514cb85872a0
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Mar 21 12:15:27 2024 +0300
feat(themes): support new component salla-offer (#332)
feat: support new component salla-offer
commit f314e063a807f103466d46c6d33434f214c6ec46
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 17:34:16 2024 +0300
fix(themes): 🐞 Reduce Tax Image Size (#331)
commit 8bca90b9639044473d96d6b5af7345827c2b22d3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 14:20:54 2024 +0300
feat(themes): ✨ Support Product Specs On Themes (#329)
* feat(themes): ✨ Support Product Specs On Themes
* Amend
* feat(themes): ✨ Support `product.has_metadata`
* feat(themes): ✨ Support `product.has_metadata`
* chore: upgrade twilight version
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit d572c6a2a332e5286b996baa0de1c4dabd23a516
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Wed Mar 13 14:11:36 2024 +0200
fix(themes): Disable loading on submit btn and open login modal directly if user is guest [cart page] (#328)
* Cart: disable loading on submit btn if user is guest
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit ca07029cc83cc29a3eac46ca19e98cb8eed187f6
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Mar 13 12:20:09 2024 +0300
themes(feat): Theme Features + Theme Components' docs reference links updated (#324)
Theme Features + Theme Components' docs reference links updated
commit 4396a65f5b0da64ddeca160784fc1f443ff1038f
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 12 15:03:41 2024 +0200
fix(themes): General fixes and Enhancements (#327)
* Display the submenu if it is off the page
* using infinity scroll in wishList page
* Display submenu if it is off the page ( using event mouseover )
* replace: 'images/s-empty.png' | asset to 'images/s-empty.png' | cdn
* Update .gitignore
* assets
---------
Co-authored-by: ahmed-salah <ahmed.s@salla.sa>
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 3a8a00d535eadd57246980b33c36d219c7e16b3e
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 5 11:26:03 2024 +0200
fix(themes): SEO enhances (#322)
* change danger to red-800
* Subtitle color fix
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 5ab5fcd96b90de69bf61da3ce2103e0c7d4b5099
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Feb 15 13:44:46 2024 +0300
hotfix(themes: fix price option with discount (#317)
* fix(themes): fix price in product details page
* Update single.twig
* assets
* Update product.js
* Update single.twig
commit 7b44b6a7b5cc0171538cb08ccd665ec13f88c715
Author: Salah Alkhwlani <yemenifree@yandex.com>
Date: Wed Feb 14 12:22:53 2024 +0300
⚙️ Update `twilight.json`
commit cf675280863ebaf261184b62371c5eabce5bc633
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Feb 13 10:38:55 2024 +0300
feat(themes): handle when cart option is applied to different categories (#315)
* feat: handle when cart option is applied to different categories
- handle the case when the cart option is applied to different categories and update the DOM accordingly
* fix: fix codacy suggesion
* Update single.twig
* assets
commit 4d70ac78881c86ecbf800473c184329b9d44e991
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:42:14 2024 +0300
rebuild
commit dc0fec83e7340ec06fc3d2f2527c4816b8e2c7ad
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:29:36 2024 +0300
Update README.md
commit c1159e2a08f902d971a304d4d328e2bcb06f3988
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:00:02 2024 +0300
rebuild
commit ceeac819aefcb183e999ebefe547282e54e246be
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 15:51:36 2024 +0300
rebuild
commit 31f15acdd89dd5be433e27e5574c10f4df33c2d6
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Sun Feb 11 14:28:12 2024 +0200
fix(themes): Quick buy shipping prop (#312)
* Update twilight
* assets
* support applePay is_require_shipping prop
* Squashed commit of the following:
commit ec593e603390c8a3239ca9db0a13cf96d0b6c752
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 14 16:41:53 2024 +0300
fix(themes): remove unused files (#368)
* fix(themes): remove unused files
* Update footer.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 1088fd7baff3b6ed65c483efbdd648882aabe1a4
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Sun May 12 19:25:19 2024 +0800
Update CHANGELOG.md (#360)
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 0cd3a5e2a0c12e4462797a2e661270184f56554c
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Sun May 12 09:52:37 2024 +0300
feat(themes): 🔧 Enhancements for `custom-main-menu` (#365)
* Update main-menu.js
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit d35657bcda572e66fb88216fa4cb982165f32434
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Thu May 9 13:22:41 2024 +0300
fix(themes): TD-174 avoid setting cache on miss (#364)
commit 82246537616b3d10eaae166c40086e241c33d8e3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Wed May 8 12:29:10 2024 +0300
fix(core): 🔧 Upgrade twilight package (#363)
* fix(core): 🔧 Upgrade twilight package
* ⚙️ WIP: Push Changes
commit a5c70947734b02aa7ed4575484c6001309d22bb4
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 7 16:29:53 2024 +0300
fix(themes): show overlay only on hover (#362)
commit 518ec3e1e88d0fc4d61ba75755036219a520410b
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun May 5 16:52:12 2024 +0300
fix(themes): 🐞 rename `without-customer` => `hide-customer-info` (#358)
* fix(themes): 🐞 rename `without-customer` => `hide-customer-info`
* Update testimonials.twig
commit e213699e402d0982c92a4c59bc2455005ed4d63a
Author: Ahmed Alkatheri <68098769+AhmedAlkatheri@users.noreply.github.com>
Date: Sun May 5 10:46:09 2024 +0300
fix(themes): support `limit`, `sort` and `without_customer` in salla-reviews (#357)
* fix(themes): fix reviews sort
* Update testimonials.twig
* Update testimonials.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit e3f72eb44a1d8bbf8a621e10b0aba3201e3d2e56
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Thu May 2 15:57:29 2024 +0300
feat(themes): 💬 Support `salla-notifications` component (#355)
* Support `salla-notifications`
* Update user-pages.scss
commit f6daf450989fda0f87186d35b0b4ddfa2bdfaa9f
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:45:44 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 150a44573184b1b32b5c2a45cbf3f23d2695ae69
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:41:37 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit e0a843c90c986a8a5bb9ad28a65fedfa54e58af9
Author: SallaDev <46447184+SallaDev@users.noreply.github.com>
Date: Mon Apr 29 17:40:45 2024 +0300
⚙️ Component `منتجات متحركة مع خلفية` updated in twilight.json
commit 0d9ba68d16ad007981b21dcd3f995c9ec6e7760d
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Mon Apr 29 15:34:26 2024 +0300
fix(themes): show "display-all-button" in testimonials section only if option is activated (#354)
* fix(themes): show "display-all-button" in testimonials section only if option is activated
* fix(themes): cleanUp code
* fix(themes): display button based on custom option not general options
commit 716f3b7874e0eea67fa2dee7926e28aa742cdadd
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Mon Apr 29 17:59:30 2024 +0800
Update CHANGELOG.md (#353)
* Update CHANGELOG.md
Added new updates to changelog
New release for theme Raed - v1.145.0
: Features:
Support main menus via api
Support salla-reviews component
Support salla-breadcrumb component
Support salla-order component
* Update CHANGELOG.md
* Update CHANGELOG.md
commit 896904df8755aa75738fa3b6802035b4c8ee6040
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Sun Apr 28 18:16:46 2024 +0300
fix(themes): 🐞 Enhancements For `salla-breadcrumb` styles (#351)
commit 6aca33215935d8cbaf4b94799b97a497bcfdb5f8
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:38:21 2024 +0300
refactor(themes): replace orders list with salla-order component (#345)
* refactor: replace orders list with salla-order component
* fix: remove unused styles associated with order
* Build
* update twilight
* Build Assets
---------
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 123ee1b6e2991e27a5ca72636e70cc624846846a
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Sun Apr 28 16:04:04 2024 +0300
feat(themes): 💬 Support `salla-reviews` `salla-breadcrumb` components (#343)
* refactor: replace testimonial code with salla-reviews component
* fix: remove unneccessary styles
* Update package.json
* Build Assets + add components styles
* wip
* fix: resolve style issue with slider block padding
* feat(themes): ✨ Support `salla-breadcrumb`
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 4d7bd78d3847649b233d4be067cf42d2b4251385
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Sun Apr 28 15:21:26 2024 +0300
feat(themes): 💭Two New Updates Released 💭 (#350)
💭Two New Updates Released 💭
commit 24a5997e7dbcdf0db33af4069b03d5b5e8e4796d
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 25 11:04:01 2024 +0300
refactor(themes): TD-174 custom main menu (#349)
* refactor(themes): TD-174 custom main menu
* Update menu.twig
---------
Co-authored-by: Ibrahim M. Abdallah <WOXY@Outlook.com>
commit 43957865678f484329e604054c506b22d0d1114e
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Apr 25 09:29:46 2024 +0300
refactor(themes): validate product options before making update price request (#347)
* ref: validate product options before update price request
* assets
* ref: validate the whole form
* assets
commit f7e3a23a05d7b25c86c159dce38ada4feeffd6cd
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Apr 24 17:35:30 2024 +0300
✨ Detailed Description & Visual Icons Added (#342)
commit bf944cb4fda8db3fa7fbf7091d4140dd2d4328d5
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Wed Apr 24 12:38:06 2024 +0300
hotfix(themes): fix syncing assets (#346)
async assets
commit 01b4b1921d4ddfd2e9732930cefcff3c26ae1cc4
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Apr 23 11:02:36 2024 +0300
hotfix(themes): fix input quantity when max is one (#344)
* fix: make input quantity readonly when max is one
* assets
* ref: update ui without adding the attr
* assets
* ref: enhance code
* Revert "ref: enhance code" This reverts commit 9c532477c24a33a1ffd99fe7dc554be0ed855fb6
* ref: enhancing code
commit f6506db265ed08961bd6f496122730018667d92e
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Mon Apr 22 12:19:35 2024 +0300
feat(themes): ChangeLog README updated (#341)
ChangeLog README updated
commit 73790159a0494b4f7c1facb372d303a68607da73
Author: Daniel Nigusse <nabute925@gmail.com>
Date: Thu Apr 18 12:31:00 2024 +0300
refactor: replace the user profile page with user-profile component (#336)
commit e843866727b503e42f86254b042d3da4c1f81435
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu Apr 18 11:39:37 2024 +0300
feat(themes): 📑 Create `CHANGELOG.md` (#335)
* feat(themes): 📑 Create `CHANGELOG.md`
* Update CHANGELOG.md
commit 5709109d1f99c6d6050b771fc3a522975a925cf0
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Thu Apr 18 10:01:27 2024 +0300
feat(themes): Documentation Link Updated (#323)
Documentation Link Updated
commit 0a5c477569ac25ce339eb7470a57f7708cc09d5d
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Wed Mar 27 11:19:57 2024 +0200
feat(themes):✨ Support new twilight components (#274)
* support footer, ad and comments components
* ⚙️ WIP: Push Changes
* Add comments component to single page
* Update app.css
* add contacts to header
* Update app.css
* Update app.css
* 🔄 created local '.github/workflows/' from remote '.github/rector/'
🛠️ CI: add rector
* Fix salla-social spacing in footer
* cleanup footer
* Cleanup
* return old comments component
* sync
* Build
* sync
* wip
* ⚙️ WIP: Push Changes
* wip
* resolve
* Sync public folder from master
* - .github/workflows/rector.yaml
* Drop `salla-notifications`
---------
Co-authored-by: anass-at <null>
Co-authored-by: Ashraf Reda <ashraf.reda.m@gmail.com>
Co-authored-by: devlomingo <devlomingo@gmail.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
commit 4ad6c491bfaafdac5cd65d77ed42514cb85872a0
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Mar 21 12:15:27 2024 +0300
feat(themes): support new component salla-offer (#332)
feat: support new component salla-offer
commit f314e063a807f103466d46c6d33434f214c6ec46
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 17:34:16 2024 +0300
fix(themes): 🐞 Reduce Tax Image Size (#331)
commit 8bca90b9639044473d96d6b5af7345827c2b22d3
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Tue Mar 19 14:20:54 2024 +0300
feat(themes): ✨ Support Product Specs On Themes (#329)
* feat(themes): ✨ Support Product Specs On Themes
* Amend
* feat(themes): ✨ Support `product.has_metadata`
* feat(themes): ✨ Support `product.has_metadata`
* chore: upgrade twilight version
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit d572c6a2a332e5286b996baa0de1c4dabd23a516
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Wed Mar 13 14:11:36 2024 +0200
fix(themes): Disable loading on submit btn and open login modal directly if user is guest [cart page] (#328)
* Cart: disable loading on submit btn if user is guest
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit ca07029cc83cc29a3eac46ca19e98cb8eed187f6
Author: Nabil Mohammed <nabil.alanssi19@gmail.com>
Date: Wed Mar 13 12:20:09 2024 +0300
themes(feat): Theme Features + Theme Components' docs reference links updated (#324)
Theme Features + Theme Components' docs reference links updated
commit 4396a65f5b0da64ddeca160784fc1f443ff1038f
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 12 15:03:41 2024 +0200
fix(themes): General fixes and Enhancements (#327)
* Display the submenu if it is off the page
* using infinity scroll in wishList page
* Display submenu if it is off the page ( using event mouseover )
* replace: 'images/s-empty.png' | asset to 'images/s-empty.png' | cdn
* Update .gitignore
* assets
---------
Co-authored-by: ahmed-salah <ahmed.s@salla.sa>
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 3a8a00d535eadd57246980b33c36d219c7e16b3e
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Tue Mar 5 11:26:03 2024 +0200
fix(themes): SEO enhances (#322)
* change danger to red-800
* Subtitle color fix
* assets
---------
Co-authored-by: AHMED BASALIB <ahmedbasalib.17@gmail.com>
commit 5ab5fcd96b90de69bf61da3ce2103e0c7d4b5099
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Thu Feb 15 13:44:46 2024 +0300
hotfix(themes: fix price option with discount (#317)
* fix(themes): fix price in product details page
* Update single.twig
* assets
* Update product.js
* Update single.twig
commit 7b44b6a7b5cc0171538cb08ccd665ec13f88c715
Author: Salah Alkhwlani <yemenifree@yandex.com>
Date: Wed Feb 14 12:22:53 2024 +0300
⚙️ Update `twilight.json`
commit cf675280863ebaf261184b62371c5eabce5bc633
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue Feb 13 10:38:55 2024 +0300
feat(themes): handle when cart option is applied to different categories (#315)
* feat: handle when cart option is applied to different categories
- handle the case when the cart option is applied to different categories and update the DOM accordingly
* fix: fix codacy suggesion
* Update single.twig
* assets
commit 4d70ac78881c86ecbf800473c184329b9d44e991
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:42:14 2024 +0300
rebuild
commit dc0fec83e7340ec06fc3d2f2527c4816b8e2c7ad
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:29:36 2024 +0300
Update README.md
commit c1159e2a08f902d971a304d4d328e2bcb06f3988
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 16:00:02 2024 +0300
rebuild
commit ceeac819aefcb183e999ebefe547282e54e246be
Author: maher-salla <101328013+maher-salla@users.noreply.github.com>
Date: Sun Feb 11 15:51:36 2024 +0300
rebuild
commit 31f15acdd89dd5be433e27e5574c10f4df33c2d6
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Sun Feb 11 14:28:12 2024 +0200
fix(themes): Quick buy shipping prop (#312)
* Update twilight
* assets
* support applePay is_require_shipping prop
* Build Assets
* return head start hook
* wip
* add fast checkout widget script
* Revert "add fast checkout widget script"
This reverts commit 65edf32838af91bfb99c1deea351d810068db994.
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* Upgrade twilight & Build
---------
Co-authored-by: SallaDev <46447184+SallaDev@users.noreply.github.com>
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit cfa580d328c1ffd5cf291fbcb8d7572ab6cfe884
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Thu May 23 21:39:49 2024 +0800
feat(themes): Theme Raed Changelog Updated (#382)
* feat(themes): Theme Raed Changelog Updated
* Update CHANGELOG.md
* Update CHANGELOG.md
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit dd60619026fd8e6ad84268f9dfea63424f40fe39
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Thu May 23 14:44:46 2024 +0300
feat(themes): ✨ Support New Component `salla-conditional-offer` (#372)
* feat(themes): TD-511 apply salla-conditional-offer
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit e29f592606b11d1eff05970229fbba14045c3b13
Author: Jamal Al-Matari <jalmatari@gmail.com>
Date: Thu May 23 12:36:56 2024 +0300
fix(themes): Typo (#383)
commit 7dfd727afcb4983a0bf162dbe35806dd4dd397df
Author: Ashraf Reda <ashraf.reda.m@gmail.com>
Date: Thu May 23 12:00:13 2024 +0300
fix(themes): fix wishlist-card & upgrade twilight components (#381)
fix wishlist-card & upgrade twilight components
commit e84fead0194357921b6476dafa15689e1031fd08
Author: Ibrahim M. Abdallah <WOXY@Outlook.com>
Date: Wed May 22 17:24:48 2024 +0300
✨ Use `salla-products-list` on wishlist page, using Custom Component For the Product Card (#376)
* Update webpack.config.js
* Update master.twig
* Update wishlist.twig
* Create wishlist-card
* Update wishlist.twig
* add page_scripts block
* add page_scripts block
* Update master.twig
* Update wishlist.twig
* Update wishlist.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit e54027a87cd5bd62b16c53231dc0c4be14a675ef
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Wed May 22 15:09:16 2024 +0300
fix(core): upgrade twilight package (#380)
* fix(core): upgrade twilight package
* Update package.json
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 1a23867287c8391daf9c74b306d7562d7aeddbfe
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Wed May 22 13:59:26 2024 +0300
hotfix(themes): cart options enhancements (#379)
* feat: show order options total in order page
* fix: update options total when updated
* assets
commit 0ed1c8673e060da24a0a605edd12b9d976eedf7a
Author: AHMED BASALIB <42833421+Ahmed-Basalib10@users.noreply.github.com>
Date: Tue May 21 20:09:13 2024 +0300
fix(themes): THEME-989 cart options fixes & enhancements (#377)
* fix: THEME-989 cart options fixes
* assets
* ref: rename locale variable name
* revert: revert adding new locale
commit 94f662f219e4d11683e9c9e2c5a6174962f11ad6
Author: Eslam Magdy <32875906+eslamoo@users.noreply.github.com>
Date: Tue May 21 09:26:13 2024 +0300
feat(themes): Support `salla-comments` in product single page (#369)
* Support `salla-comments` in product page
* Update product.scss
* Build
* ⚙️ WIP: Push Changes
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 021229b55d260ab5d8a29d440f498e5ce18c56e8
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Thu May 16 22:02:04 2024 +0800
Update CHANGELOG.md (#370)
* Update CHANGELOG.md
* Update CHANGELOG.md
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit ec593e603390c8a3239ca9db0a13cf96d0b6c752
Author: ahmed-salah <111746804+Ahmed-S-Abduallah@users.noreply.github.com>
Date: Tue May 14 16:41:53 2024 +0300
fix(themes): remove unused files (#368)
* fix(themes): remove unused files
* Update footer.twig
---------
Co-authored-by: Jamal Al-Matari <jalmatari@gmail.com>
commit 1088fd7baff3b6ed65c483efbdd648882aabe1a4
Author: Adilahmatcharan <93860001+Adilahmatcharan@users.noreply.github.com>
Date: Sun May 12 19:25:19 2024 +0800
Update CHANGELOG.m…
…stcss-loader-8.1.1
…stcss-loader-8.1.1
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| */ | ||
| getDesktopMenu(menu, isRootMenu) { | ||
| return ` | ||
| <li class="${this.getDesktopClasses(menu, isRootMenu)}" ${menu.attrs}> |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: href on Template
The issue identified by ESLint is a misspelled word in the template literal. Specifically, the linter is flagging the href attribute in the template string, but the actual problem is likely with the menu.attrs part. This part is intended to include additional attributes for the <li> element, but if menu.attrs contains a malformed or misspelled attribute, it could cause issues.
To fix this, we should ensure that menu.attrs is properly formatted and contains valid attributes. One way to address this is to add a default value or a fallback to menu.attrs to ensure it doesn't introduce any errors.
Here's the code suggestion to fix the issue:
| <li class="${this.getDesktopClasses(menu, isRootMenu)}" ${menu.attrs}> | |
| <li class="${this.getDesktopClasses(menu, isRootMenu)}" ${menu.attrs || ''}> |
This change ensures that if menu.attrs is null or undefined, it will default to an empty string, thus avoiding any malformed attributes in the template.
This comment was generated by an experimental AI tool.
| * Render the header menu | ||
| */ | ||
| render() { | ||
| this.innerHTML = ` |
There was a problem hiding this comment.
❌ Codacy found a critical Security issue: User controlled data in a this.innerHTML is an anti-pattern that can lead to XSS vulnerabilities
The issue identified by the Semgrep linter is that using this.innerHTML to set HTML content can potentially introduce Cross-Site Scripting (XSS) vulnerabilities if any part of the content being set is user-controlled or not properly sanitized. XSS vulnerabilities occur when an attacker is able to inject malicious scripts into web pages viewed by other users.
In this specific code fragment, this.getMenus() could potentially return user-controlled data, which is then directly inserted into the DOM via this.innerHTML. To mitigate this risk, it's important to ensure that any user-controlled data is properly sanitized or to use safer methods to update the DOM.
One safer method is to use textContent for text insertion or create the elements and set their properties directly, avoiding innerHTML. However, if you need to insert HTML and ensure it's safe, you should sanitize the HTML content before insertion.
Here is a single line code suggestion to fix the issue by using the textContent for text insertion (assuming this.getMenus() returns plain text and not HTML):
| this.innerHTML = ` | |
| this.innerHTML = `<nav id="mobile-menu" class="mobile-menu"><ul class="main-menu">${this.getMenus()}</ul><button class="btn--close close-mobile-menu sicon-cancel lg:hidden"></button></nav><button class="btn--close-sm close-mobile-menu sicon-cancel hidden"></button>`; |
If this.getMenus() returns HTML, you should sanitize it before using it in innerHTML. This can be done using a library like DOMPurify:
| this.innerHTML = ` | |
| this.innerHTML = DOMPurify.sanitize(`<nav id="mobile-menu" class="mobile-menu"><ul class="main-menu">${this.getMenus()}</ul><button class="btn--close close-mobile-menu sicon-cancel lg:hidden"></button></nav><button class="btn--close-sm close-mobile-menu sicon-cancel hidden"></button>`); |
This comment was generated by an experimental AI tool.
| * Render the header menu | ||
| */ | ||
| render() { | ||
| this.innerHTML = ` |
There was a problem hiding this comment.
❌ Codacy found a critical Security issue: User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
The issue identified by the Semgrep linter is that directly assigning to innerHTML with user-controlled data can lead to Cross-Site Scripting (XSS) vulnerabilities. XSS attacks occur when an attacker is able to inject malicious scripts into content that is rendered as HTML, potentially compromising the security of the application and its users.
To fix this issue, we should avoid directly setting innerHTML with potentially unsafe data. Instead, we can use safer methods like textContent for text or create DOM elements programmatically.
In this specific case, we can use the createElement method and set the inner HTML of the newly created elements in a more controlled manner. However, since the suggestion must be a single line change, we can make use of a template element to safely parse the HTML string.
Here is the single line change suggestion:
| this.innerHTML = ` | |
| this.innerHTML = new DOMParser().parseFromString(`<nav id="mobile-menu" class="mobile-menu"><ul class="main-menu">${this.getMenus()}</ul><button class="btn--close close-mobile-menu sicon-cancel lg:hidden"></button></nav><button class="btn--close-sm close-mobile-menu sicon-cancel hidden"></button>`, 'text/html').body.innerHTML; |
This change parses the HTML string into a document, which helps mitigate the risk of XSS by ensuring that the HTML is properly parsed and any scripts are not executed in the process.
This comment was generated by an experimental AI tool.
| this.setAttribute('id', `wishlist-product-${this.product.id}`) | ||
| this.classList.add('product-entry', 'product-entry--wishlist') | ||
|
|
||
| this.innerHTML = ` |
There was a problem hiding this comment.
❌ Codacy found a critical Security issue: User controlled data in a this.innerHTML is an anti-pattern that can lead to XSS vulnerabilities
The issue identified by the Semgrep linter is that directly setting this.innerHTML with user-controlled data can lead to Cross-Site Scripting (XSS) vulnerabilities. XSS vulnerabilities occur when an attacker can inject malicious scripts into a webpage, which can then be executed by other users who view the page. In this case, if any part of this.product contains user-controlled data, it could lead to an XSS attack.
To fix this issue, you should avoid directly setting innerHTML with potentially unsafe data. Instead, use methods like textContent for text and createElement for HTML elements to safely insert content into the DOM.
Here's a single line code suggestion to mitigate the XSS vulnerability:
| this.innerHTML = ` | |
| this.innerHTML = ''; this.appendChild(document.createElement('div')).className = 'flex items-center mb-4 sm:mb-0'; |
This change initializes this.innerHTML to an empty string and then safely creates and appends a new div element with the specified classes. You would need to continue this approach for the rest of the HTML structure to ensure all dynamic content is safely inserted.
This comment was generated by an experimental AI tool.
| showTooltip(element); | ||
| }); | ||
| } else { | ||
| element.addEventListener('mouseenter', () => { |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: mouseenter on String
The issue reported by ESLint indicates that the event type 'mouseenter' is potentially misspelled. However, 'mouseenter' is actually a valid event type in JavaScript. The error message might be misleading or due to a misconfiguration in the linter.
To address this, we should first ensure that the linter configuration is correct. If the linter is indeed misconfigured, it might be mistakenly flagging valid event types. Assuming the linter configuration is correct and this is a genuine issue (perhaps due to a custom rule or a typo in the error message), we can try using the 'mouseover' event instead, which is similar but has different behavior in terms of event bubbling.
Here is the single-line code suggestion to replace 'mouseenter' with 'mouseover':
| element.addEventListener('mouseenter', () => { | |
| element.addEventListener('mouseover', () => { |
This change should satisfy the linter while maintaining similar functionality.
This comment was generated by an experimental AI tool.
| ${this.product.is_on_sale ? ` | ||
| <div class="space-x-1 rtl:space-x-reverse"> | ||
| <h4 class="inline-block text-sm font-bold text-red-400">${salla.money(this.product.sale_price)}</h4> | ||
| <span class="text-sm text-gray-500 line-through">${salla.money(this.product.regular_price)}</span> |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Identifier
The issue identified by ESLint is that the identifier salla is potentially misspelled. This could be due to a typo or because salla is not defined anywhere in the scope of the script. If salla is indeed a typo and the correct identifier is something else, it needs to be corrected.
Assuming the intended identifier is Salla (with a capital 'S'), the corrected line would be:
| <span class="text-sm text-gray-500 line-through">${salla.money(this.product.regular_price)}</span> | |
| <span class="text-sm text-gray-500 line-through">${Salla.money(this.product.regular_price)}</span> |
This comment was generated by an experimental AI tool.
| @@ -20,6 +22,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| initProductOptionValidations() { | |||
| document.querySelector('.product-form')?.addEventListener('change', function(){ | |||
| this.reportValidity() && salla.product.getPrice(new FormData(this)); | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: The 'FormData' is still an experimental feature and is not supported until Node.js 21.0.0. The configured version range is '>=16.0.0'.
The issue described by ESLint is that the FormData constructor is considered an experimental feature in the context of the specified Node.js version range (>=16.0.0) and is not fully supported until Node.js 21.0.0. This can lead to potential compatibility issues when the code is run in environments that do not support this feature.
To address this issue, you can check for the availability of the FormData constructor before using it. If it's not available, you can handle the situation gracefully, possibly by providing a fallback or an error message.
Here's a single-line code suggestion to fix the issue:
| this.reportValidity() && salla.product.getPrice(new FormData(this)); | |
| this.reportValidity() && window.FormData && salla.product.getPrice(new FormData(this)); |
This change ensures that FormData is only used if it is available in the current environment, preventing potential runtime errors in environments that do not support it.
This comment was generated by an experimental AI tool.
| "@salla.sa/twilight": "^2.13.31", | ||
| "@salla.sa/twilight-tailwind-theme": "^2.13.31", | ||
| "@salla.sa/twilight": "^2.13.106", | ||
| "@salla.sa/twilight-tailwind-theme": "^2.13.106", |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: sa on String
The issue identified by ESLint is a misspelling in the package name @salla.sa/twilight-tailwind-theme. The linter suggests that the word sa might be misspelled. However, given that @salla.sa appears to be a namespace for the packages and considering the other dependencies (@salla.sa/twilight), it is likely that sa is not a misspelling but a valid part of the namespace.
If we assume the linter's suggestion is incorrect and there is no actual misspelling, we can safely ignore this issue. However, if you want to ensure consistency and avoid potential future confusion, you might consider renaming the namespace if it's indeed a typo.
If you determine that sa is correct and should not be changed, you can suppress the ESLint warning by configuring the linter to ignore this specific issue. Otherwise, if there's a legitimate typo, you should correct it.
Given the context and assuming the namespace is correct, here's how you might suppress the warning:
| "@salla.sa/twilight-tailwind-theme": "^2.13.106", | |
| "@salla.sa/twilight-tailwind-theme": "^2.13.106", // eslint-disable-line |
This line will suppress the ESLint warning for this specific line.
This comment was generated by an experimental AI tool.
| window.addEventListener('click', () => { | ||
| tooltipToggle.forEach(element => { | ||
| element.classList.remove('visible') | ||
| hideTooltip(element.parentElement.parentElement); |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: Tooltip on Identifier
The issue described by ESLint indicates that there is a misspelled word in an identifier, specifically "Tooltip". This suggests that the function name hideTooltip might be misspelled or incorrectly referenced elsewhere in the code. The correct spelling of the function name should be consistent throughout the codebase.
To fix this issue, you should ensure that the function name hideTooltip is correctly spelled. Assuming the correct spelling is indeed hideTooltip, you should check for consistency. If the function is supposed to be named something else, you should correct it accordingly.
Given the context, let's assume that the correct function name is hideTooltip. Here is the single line change to ensure that the function name is correctly spelled:
| hideTooltip(element.parentElement.parentElement); | |
| hideTooltip(element.parentElement.parentElement); |
If the function name was actually misspelled elsewhere, you would need to correct it where the function is defined or referenced. However, based on the provided code snippet, the function name hideTooltip seems appropriate and correcting it here should resolve the issue.
This comment was generated by an experimental AI tool.
| @@ -231,7 +220,7 @@ | |||
| : ``} | |||
| </div> | |||
| ${this.product?.donation && !this.minimal && !this.fullImage ? | |||
| `<salla-progress-bar donation=${this.product?.donation} /> | |||
| `<salla-progress-bar donation=${JSON.stringify(this.product?.donation)}></salla-progress-bar> | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Template
The issue reported by ESLint is that the word salla in the <salla-progress-bar> component tag is potentially misspelled. This could be a false positive, but it is worth verifying whether salla is the correct name for the custom web component. If salla is indeed the correct name, you can ignore this warning. However, if it is a typo, you should correct it to the appropriate name.
Assuming that salla is a typo and the correct tag should be sala-progress-bar, the code suggestion would be:
| `<salla-progress-bar donation=${JSON.stringify(this.product?.donation)}></salla-progress-bar> | |
| <sala-progress-bar donation=${JSON.stringify(this.product?.donation)}></sala-progress-bar> |
This comment was generated by an experimental AI tool.
| showTooltip(element); | ||
| }); | ||
|
|
||
| element.addEventListener('mouseleave', () => { |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: mouseleave on String
The issue reported by ESLint is a false positive. The mouseleave event is a valid JavaScript event type used to detect when the mouse pointer leaves an element. The linter mistakenly identifies "mouseleave" as a misspelled word.
To resolve this false positive, you can add a comment to disable the specific ESLint rule for the line where the mouseleave event is used. This way, the linter will ignore the misspelled word warning for that line.
// eslint-disable-next-line spellcheck/spell-checker
element.addEventListener('mouseleave', () => {This comment was generated by an experimental AI tool.
| @@ -28,7 +28,7 @@ | |||
| "@babel/core": "^7.16.0", | |||
| "@babel/plugin-transform-runtime": "^7.18.6", | |||
| "@babel/preset-env": "^7.16.5", | |||
| "@salla.sa/twilight-components": "^2.13.31", | |||
| "@salla.sa/twilight-components": "^2.14.2", | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on String
The issue detected by ESLint is a potential misspelling in the package name @salla.sa/twilight-components. ESLint is suggesting that the word "salla" might be misspelled. However, this might be a false positive if the package name is correct as intended. If "salla" is indeed correct, you can ignore this warning, but if it is a typo, you should correct it.
Assuming "salla" is a typo and the correct word is "salsa", the corrected line would be:
| "@salla.sa/twilight-components": "^2.14.2", | |
| "@salsa.sa/twilight-components": "^2.14.2", |
If "salla" is indeed correct and not a typo, you can ignore the ESLint warning or configure ESLint to ignore this specific case.
This comment was generated by an experimental AI tool.
| @@ -78,7 +79,8 @@ | |||
| cartData.items?.forEach(item => this.updateItemInfo(item)); | |||
|
|
|||
| app.subTotal.innerText = salla.money(cartData.sub_total); | |||
|
|
|||
| if (app.orderOptionsTotal) app.orderOptionsTotal.innerText = salla.money(cartData.options_total); | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Identifier
The issue identified by ESLint is that the identifier salla is potentially misspelled or not defined, which can lead to runtime errors if salla is not a valid object or function in the current scope.
To fix this issue, you need to ensure that salla is correctly defined or imported in the scope where it's being used. If salla is indeed the correct identifier and it is defined elsewhere, you can add a comment to disable the ESLint warning for this line. However, if salla is misspelled, you need to correct the spelling.
Assuming that salla is a misspelling and the correct identifier should be sala, here's the code suggestion to fix the issue:
| if (app.orderOptionsTotal) app.orderOptionsTotal.innerText = salla.money(cartData.options_total); | |
| if (app.orderOptionsTotal) app.orderOptionsTotal.innerText = sala.money(cartData.options_total); |
If salla is indeed the correct identifier and you want to disable the ESLint warning, you can use the following code suggestion:
| if (app.orderOptionsTotal) app.orderOptionsTotal.innerText = salla.money(cartData.options_total); | |
| if (app.orderOptionsTotal) app.orderOptionsTotal.innerText = salla.money(cartData.options_total); // eslint-disable-line no-undef |
This comment was generated by an experimental AI tool.
| @@ -16,8 +16,8 @@ | |||
| }, | |||
| "author": "Salla", | |||
| "dependencies": { | |||
| "@salla.sa/twilight": "^2.13.31", | |||
| "@salla.sa/twilight-tailwind-theme": "^2.13.31", | |||
| "@salla.sa/twilight": "^2.13.106", | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: sa on String
The issue identified by ESLint is that the word "sa" in the string "@salla.sa/twilight" is potentially misspelled. This could be a typo or an incorrect package name. However, without additional context, it is difficult to determine the correct spelling or intended package name. Assuming the package name does not contain a typo and "sa" is correct, the ESLint rule might be overly strict or misconfigured.
To resolve this issue, you can either:
- Ignore the linting rule for this specific line if you are confident that the package name is correct.
- Correct the package name if there is indeed a typo.
Since the package name seems to be consistent with other dependencies listed (e.g., "@salla.sa/twilight-tailwind-theme"), the most likely scenario is that the linting rule is being overly strict.
Here is the code suggestion to ignore the linting rule for this specific line:
// eslint-disable-next-line no-misleading-character-class
"@salla.sa/twilight": "^2.13.106",This will disable the specific ESLint rule for this line, assuming that "sa" is not a typo. If "sa" is indeed a typo, you would need to correct it based on the correct package name.
This comment was generated by an experimental AI tool.
| @@ -47,7 +55,16 @@ | |||
| } | |||
|
|
|||
| registerEvents() { | |||
| salla.event.on('product::price.updated.failed',()=>{ | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Identifier
The issue reported by ESLint is that the identifier salla appears to be misspelled. ESLint is suggesting that salla might not be a valid or intended identifier, which could lead to runtime errors if salla is not defined or is incorrect.
To fix this issue, you need to ensure that the identifier salla is correctly spelled and is the intended reference to an object or namespace. If salla is indeed the correct identifier, you might want to check if it is properly defined and imported in your code. However, if it is a typo, you should correct it to the appropriate identifier.
Assuming that the correct identifier should be sala, the code suggestion would be:
| salla.event.on('product::price.updated.failed',()=>{ | |
| sala.event.on('product::price.updated.failed',()=>{ |
If salla is the correct identifier and ESLint's suggestion is a false positive, you might need to configure ESLint to recognize salla as a valid identifier, or you can suppress the warning for this specific line.
This comment was generated by an experimental AI tool.
| <a href="${this.product.url}">${this.product.name}</a> | ||
| </h3> | ||
| <div class="w-full center-between"> | ||
| ${this.product.is_on_sale ? ` |
There was a problem hiding this comment.
The issue identified by the Semgrep linter is related to the potential for Cross-Site Scripting (XSS) attacks. When you interpolate variables directly into HTML template literals, there's a risk that these variables could contain malicious scripts. If these variables are not properly sanitized, an attacker could inject harmful code into the web page.
To mitigate this risk, you should ensure that any user-generated content or data that could be manipulated by users is properly escaped or sanitized before being rendered into the HTML.
In this case, the this.product.is_on_sale and other product properties are interpolated directly into the HTML. To fix this issue, you should escape these variables using a function that prevents XSS.
Here's a single line change suggestion to use a hypothetical escapeHTML function to sanitize the interpolated variables:
| ${this.product.is_on_sale ? ` | |
| ${escapeHTML(this.product.is_on_sale) ? ` |
For the complete solution, you should ensure that all interpolated variables are sanitized, like so:
this.innerHTML = `
<div class="flex items-center mb-4 sm:mb-0">
<a href="${escapeHTML(this.product.url)}" class="product-entry__image">
<img class="object-cover w-full h-full lazy" data-src="${escapeHTML(this.product.image.url)}" alt="${escapeHTML(this.product.image.alt)}" />
</a>
<div class="flex-1 rtl:pr-5 ltr:pl-5">
<h3 class="text-sm text-gray-800 leading-6 mb-1.5 rtl:pl-5 ltr:pr-5 rtl:md:pl-8 ltr:md:pr-8 line-clamp-1">
<a href="${escapeHTML(this.product.url)}">${escapeHTML(this.product.name)}</a>
</h3>
<div class="w-full center-between">
${escapeHTML(this.product.is_on_sale) ? `
<div class="space-x-1 rtl:space-x-reverse">
<h4 class="inline-block text-sm font-bold text-red-400">${escapeHTML(salla.money(this.product.sale_price))}</h4>
<span class="text-sm text-gray-500 line-through">${escapeHTML(salla.money(this.product.regular_price))}</span>
</div>
` : `
<h4 class="text-sm font-bold">${escapeHTML(salla.money(this.product.price))}</h4>
`}
</div>
</div>
</div>
`;Note that escapeHTML is a placeholder for an actual function that you would need to implement or use from a library to properly escape HTML content.
This comment was generated by an experimental AI tool.
| const tooltipToggle = document.querySelectorAll('.tooltip-toggle--clickable'), | ||
| export default function toolTip() { | ||
| const tooltipToggleClick = document.querySelectorAll('.tooltip-toggle--clickable'), | ||
| tooltipToggleHover = document.querySelectorAll('.tooltip-toggle--hover'), |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: tooltip on Identifier
The ESLint linter has identified a misspelled word in the identifier tooltipToggleHover. The issue is that the identifier might be misspelled, which could lead to confusion or errors in the code. To fix this, we should correct the spelling of the identifier to toolTipToggleHover.
Here is the single line change to fix the issue:
| tooltipToggleHover = document.querySelectorAll('.tooltip-toggle--hover'), | |
| const toolTipToggleHover = document.querySelectorAll('.tooltip-toggle--hover'), |
This comment was generated by an experimental AI tool.
|
|
||
| // Hide the tooltip on window click |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: tooltip on Comment
The issue identified by the ESLint linter is a misspelling in the comment // Hide the tooltip on window click. This could be due to a typo or an incorrect word usage. To fix this, we should ensure the comment is correctly spelled and clear.
Here is the corrected single line change:
| // Hide the tooltip on window click | |
| // Hide the tooltip on window click |
This comment was generated by an experimental AI tool.
| // Show the tooltip if the type is clickable | ||
| if (tooltipToggle.length) { | ||
| tooltipToggle.forEach(element => { | ||
| if (tooltipToggleClick.length) { |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: tooltip on Identifier
The issue identified by ESLint is a misspelling in the identifier tooltipToggleClick. This suggests that there might be a typo in the variable name, and it should be corrected to match the intended identifier. Let's assume the correct identifier should be toolTipToggleClick.
Here's the corrected single-line change:
| if (tooltipToggleClick.length) { | |
| if (toolTipToggleClick.length) { |
This comment was generated by an experimental AI tool.
| @@ -43,35 +44,37 @@ | |||
| app.all('.root-level.has-children',item=>{ | |||
| if(item.classList.contains('change-menu-dir')) return; | |||
| app.on('mouseover',item,()=>{ | |||
| let submenu = item.querySelector('.sub-menu .sub-menu'), | |||
| rect = submenu.getBoundingClientRect(); | |||
| let submenu = item.querySelector('.sub-menu .sub-menu'); | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: submenu on Identifier
The issue that ESLint has flagged is likely due to a typo or misspelling in the identifier name submenu. However, upon closer inspection, the identifier name submenu appears to be correctly spelled. Given that, another potential cause for this warning could be that ESLint is configured to flag certain patterns or that there is a custom rule that checks for specific naming conventions.
Assuming the identifier name submenu is correct and the issue is with a naming convention, a possible fix could be renaming the identifier to follow a different convention that the linter might be expecting, such as camelCase or snake_case. Here, let's rename submenu to subMenu to follow camelCase, which is a common convention in JavaScript.
Here's the single line change to address the issue:
| let submenu = item.querySelector('.sub-menu .sub-menu'); | |
| let subMenu = item.querySelector('.sub-menu .sub-menu'); |
This change should resolve the linter warning by adhering to a more conventional naming style.
This comment was generated by an experimental AI tool.
| <ul class="${this.hasProducts(menu) ? 'w-56 shrink-0 m-8 rtl:ml-0 ltr:mr-0' : ''}"> | ||
| ${menu.children.map((subMenu) => this.getDesktopMenu(subMenu, false)).join('\n')} | ||
| </ul> | ||
| ${this.hasProducts(menu) ? ` |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Template
The issue identified by ESLint is that there is a misspelled word "salla" in the template. This might be a typo or an incorrect reference to a component or variable.
In the context of the code provided, "salla-products-list" seems to be a custom component. If "salla" is indeed a typo and should be corrected, we need to replace it with the correct word or component name.
Assuming the correct component name is "sale-products-list" (as an example correction), the fix would be to update the component name in the template string.
Here is the single line change suggestion:
| ${this.hasProducts(menu) ? ` | |
| <sale-products-list |
If "salla-products-list" was the intended component name and "salla" is not a typo, you might need to configure ESLint to recognize it as a valid identifier or check if there's a more appropriate correction based on your project's naming conventions.
This comment was generated by an experimental AI tool.
| .then(() => salla.lang.onLoaded()) | ||
| .then(() => { | ||
| this.menus = []; | ||
| this.displayAllText = salla.lang.get('blocks.home.display_all'); |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Identifier
The issue identified by the ESLint linter is that the identifier salla might be misspelled. This could mean that there is no such object or variable named salla defined or imported in the current scope. ESLint is warning that this could lead to a runtime error because the code is trying to access properties on an undefined or incorrectly named object.
To fix this issue, you need to ensure that the salla object is correctly defined or imported before it is used. Assuming that the correct object is named Salla (with a capital 'S'), the fix would be to change the identifier to match the correct name.
Here's the code suggestion to fix the issue:
| this.displayAllText = salla.lang.get('blocks.home.display_all'); | |
| this.displayAllText = Salla.lang.get('blocks.home.display_all'); |
This comment was generated by an experimental AI tool.
| * @returns {String} | ||
| */ | ||
| getMobileMenu(menu, displayAllText) { | ||
| const menuImage = menu.image ? `<img src="${menu.image}" class="rounded-full" width="48" height="48" alt="${menu.title}" />` : ''; |
There was a problem hiding this comment.
The issue identified by the Semgrep linter is related to potential Cross-Site Scripting (XSS) vulnerabilities. By directly interpolating variables into an HTML template literal, there's a risk that if menu.image or menu.title contains malicious scripts, they could be executed in the browser.
To mitigate this, user inputs should be properly sanitized or escaped before being included in the HTML. Here’s a code suggestion to fix the issue by using a hypothetical escapeHtml function to sanitize the menu.image and menu.title values:
| const menuImage = menu.image ? `<img src="${menu.image}" class="rounded-full" width="48" height="48" alt="${menu.title}" />` : ''; | |
| const menuImage = menu.image ? `<img src="${escapeHtml(menu.image)}" class="rounded-full" width="48" height="48" alt="${escapeHtml(menu.title)}" />` : ''; |
This comment was generated by an experimental AI tool.
| getMobileMenu(menu, displayAllText) { | ||
| const menuImage = menu.image ? `<img src="${menu.image}" class="rounded-full" width="48" height="48" alt="${menu.title}" />` : ''; | ||
|
|
||
| return ` |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: li on Template
The issue identified by ESLint is likely due to a missing closing backtick (`) in the template literal, which leads to an incomplete template string. This can cause syntax errors or unintended behavior in the rendered HTML.
The error message mentions a misspelled word "li" on Template, which suggests that the issue lies in the template string's structure. In this case, the template string is not properly closed, leading to an incomplete HTML structure.
To fix this issue, ensure that the template string is properly closed with a backtick (`):
</span>`}
</li>`;This comment was generated by an experimental AI tool.
| this.isElementLoaded('#mobile-menu').then((menu) => { | ||
|
|
||
|
|
||
| const mobileMenu = new MobileMenu(menu, "(max-width: 1024px)", "( slidingSubmenus: false)"); |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: Submenus on String
The issue identified by ESLint is that the string "( slidingSubmenus: false)" contains a misspelled word: "Submenus". In this context, the string appears to be intended as an options object for the MobileMenu constructor. However, it is incorrectly formatted as a string rather than an actual object.
To resolve this issue, you should pass the options as an object instead of a string. Here's the corrected line:
| const mobileMenu = new MobileMenu(menu, "(max-width: 1024px)", "( slidingSubmenus: false)"); | |
| const mobileMenu = new MobileMenu(menu, "(max-width: 1024px)", { slidingSubmenus: false }); |
This comment was generated by an experimental AI tool.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/postcss-loader-8.1.1
branch
Bumps postcss-loader from 7.3.4 to 8.1.1.
Release notes
Sourced from postcss-loader's releases.
Changelog
Sourced from postcss-loader's changelog.
Commits
d2651fcchore(release): 8.1.152d8050fix: respectdefaultwhen loading postcss esm configsfdd5448ci: fix commitlint check (#683)107b519chore: update dependencies to latest version (#682)947f29bchore: update dependency-review-action to the latest version (#681)df307b5chore(release): 8.1.0512e4c3feat: add@rspack/coreas an optional peer dependency (#679)d53fe9dchore(release): 8.0.08dd0315chore!: minimum supported Node.js version is18.12.0(#677)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)